fix(git): fix repo scan result caching #6179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/git-repo-caching
branch
from
efc4e12 to
bc6e445
Compare
vvagaytsev
force-pushed
the
fix/git-repo-caching
branch
from
bc6e445 to
0bb7efc
Compare
vvagaytsev
force-pushed
the
fix/git-repo-caching
branch
from
0bb7efc to
1230f51
Compare
vvagaytsev
force-pushed
the
fix/git-repo-caching
branch
from
088fec6 to
667e5ba
Compare
vvagaytsev
force-pushed
the
fix/git-repo-caching
branch
from
667e5ba to
905fa68
Compare
stefreak
reviewed
Jun 18, 2024
| }) { | ||
| return hashString( | ||
| stableStringify({ | ||
| filter: filter ? filter.toString() : undefined, // We hash the source code of the filter function if provided. |
There was a problem hiding this comment.
Because it's such an unusual thing to do, and it has some implications (e.g. captured variables will not affect the hash key) I think it's better to not hide the fact that we are converting the function to a string, by changing the signature of the function, something like the following:
export function getHashedFilterParams({
filterFnSource,
augmentedIncludes,
augmentedExcludes,
}: {
filterFnSource: string | undefined
augmentedIncludes: string[]
augmentedExcludes: string[]
}) {
stefreak
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes cache key construction in
GitRepoHandlerthat accounts for different includes/excludes and filter functions for the same path.Originally, the caching was implemented in #5710. This PR makes sure that 2 filter-objects are considered tom have the equal cache keys if the difference is only in the order of the
augmentedExcludesandaugmentedIncludesarrays, ad there is no difference between the sets of values of both arrays.Which issue(s) this PR fixes:
A follow-up PR for #5526 and #5710
Special notes for your reviewer:
The changes made #5710 make the caching inThe caching inGitRepoHandler.scanRoot(...)unnecessary. That caching logic will be removed in a separate PR.GitRepoHandler.scanRoot(...)might still make sense. It caches the results for the whole path, without taking include/exclude filters into account.